Skip to content

edgeoperator: az aldo system-readiness show (preview) - #10205

Open
kleyvaortega wants to merge 7 commits into
Azure:mainfrom
kleyvaortega:users/kleyvaortega/systemReadinessExtensions
Open

edgeoperator: az aldo system-readiness show (preview)#10205
kleyvaortega wants to merge 7 commits into
Azure:mainfrom
kleyvaortega:users/kleyvaortega/systemReadinessExtensions

Conversation

@kleyvaortega

@kleyvaortega kleyvaortega commented Aug 11, 2026

Copy link
Copy Markdown

Summary

Adds a new preview Azure CLI extension edgeoperator exposing the read-only command:

  • az aldo system-readiness show - GET on Microsoft.EdgeOperator/systemReadiness/default (subscription-scoped singleton), API version 2026-06-01-preview.

Details

Tests

  • Unit test (test_custom.py) validates URL construction and dispatch.
  • Scenario/playback test (test_system_readiness_scenario.py) validates the public response shape with unified properties.categories entries and recording processors that:
    • drop private-cloud auth interactions when re-recording live,
    • normalize the ARM host so playback is environment-independent.
  • Recording is sanitized: no tokens, no private endpoints, mocked subscription id.
  • azdev style, azdev linter, azdev test, and azdev extension build passed during local PR validation.

Notes for reviewers

  • The REST specification is public and merged.
  • The extension intentionally calls ARM through send_raw_request; it does not depend on publication of a generated management SDK package.

kleyvaortega and others added 2 commits August 11, 2026 14:04
…iness show

Add recording processors to the scenario test to drop private-cloud auth
interactions and normalize the ARM host, and sanitize the recording so it
contains no tokens or private ALDO endpoints. Playback runs offline.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@azure-client-tools-bot-prd

Copy link
Copy Markdown

Hi kleyvaortega,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in pyproject.toml (or setup.py, if the extension has not migrated yet) as well.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@x-engineering-agent

Copy link
Copy Markdown

Automated sensitive-information remediation ran on this pull request.

  • Detected categories: email address
  • Replaced with typed [REDACTED:category] placeholders in: PR description
  • Could not edit: file changes on a fork branch
  • Comment/review owners notified because Agent Assist cannot edit another user's text: none

If a credential was exposed, rotate or revoke it immediately. Detected values are never copied into this comment.

✅ Keep the redaction · ❌ Dispute the redaction

GitHub only supports a fixed reaction set, so 👍 represents ✅ and 👎 represents ❌. The bot-created reactions are only poll choices.


Posted by agent-assist (autonomous bug-fix pipeline).

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@yonzhan

Copy link
Copy Markdown
Collaborator

aldo

kleyvaortega and others added 3 commits August 11, 2026 18:11
Add MIT license headers to the 7 source/test files that were missing them
(Check License gate), and register the `az aldo` command group in
src/service_name.json as "ALDO EdgeOperator" (azdev linter/style service
name gate).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Map the az aldo umbrella group to "Azure Local Disconnected Operations"
and the EdgeOperator sub-group az aldo system-readiness to "Edge Operator",
so future non-EdgeOperator ALDO commands are not mislabeled.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…into users/kleyvaortega/systemReadinessExtensions

# Conflicts:
#	src/service_name.json
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@a0x1ab Aditya Pujara (a0x1ab) added X Engineering Agent Reviewed Pull request reviewed by X Engineering Agent and removed azure-client-tools-agent labels Sep 2, 2026
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

@kleyvaortega
kleyvaortega marked this pull request as ready for review September 9, 2026 22:36
Copilot AI lite review requested due to automatic review settings September 9, 2026 22:36
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Packaging/service-attribution details need adjustment to avoid misleading wheel metadata and inconsistent command-to-service mapping.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR introduces a new preview Azure CLI extension (edgeoperator / azext_edgeoperator) that adds the read-only command az aldo system-readiness show, implemented via send_raw_request to query the subscription-scoped singleton Microsoft.EdgeOperator/systemReadiness/default using API version 2026-06-01-preview.

Changes:

  • Adds the new edgeoperator extension package with command loader, help, command registration, and raw ARM call implementation.
  • Adds unit + scenario tests (with recording processors and a sanitized recording) to validate URL construction and response shape.
  • Updates command-to-service attribution (src/service_name.json) and adds a CODEOWNERS entry for the new extension folder.
File summaries
File Description
src/service_name.json Adds service attribution entries for az aldo and az aldo system-readiness.
src/edgeoperator/setup.py Adds packaging metadata and setuptools configuration for the new extension.
src/edgeoperator/setup.cfg Adds wheel build configuration for the new extension.
src/edgeoperator/README.rst Documents the extension and the system-readiness show command.
src/edgeoperator/HISTORY.rst Introduces initial release notes for version 0.1.0.
src/edgeoperator/azext_edgeoperator/custom.py Implements the system-readiness show raw ARM GET request.
src/edgeoperator/azext_edgeoperator/commands.py Registers aldo system-readiness show as a custom show command.
src/edgeoperator/azext_edgeoperator/azext_metadata.json Marks the extension as preview and sets min CLI core version.
src/edgeoperator/azext_edgeoperator/_params.py Adds (currently empty) argument loader entrypoint.
src/edgeoperator/azext_edgeoperator/_help.py Adds help text for aldo and aldo system-readiness show.
src/edgeoperator/azext_edgeoperator/init.py Adds the extension command loader wiring.
src/edgeoperator/azext_edgeoperator/tests/latest/test_system_readiness_scenario.py Adds a scenario test with recording processors to normalize ARM host and filter private auth traffic.
src/edgeoperator/azext_edgeoperator/tests/latest/test_custom.py Adds a unit test validating singleton URL construction and request dispatch.
src/edgeoperator/azext_edgeoperator/tests/latest/recordings/test_system_readiness_show.yaml Adds a sanitized scenario test recording.
src/edgeoperator/azext_edgeoperator/tests/latest/init.py Adds test package init (new file).
src/edgeoperator/azext_edgeoperator/tests/init.py Adds test package init (new file).
.github/CODEOWNERS Adds code ownership for /src/edgeoperator/.
Review details
  • Files reviewed: 15/17 changed files
  • Comments generated: 3
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/edgeoperator/setup.py Outdated
Comment thread src/edgeoperator/setup.cfg Outdated
Comment thread src/service_name.json
@yonzhan

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

X Engineering Agent Reviewed Pull request reviewed by X Engineering Agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants